[ISSUE #73] Add remoting service #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pil0tXia
reviewed
Mar 28, 2024
...h-dashboard-common/src/main/java/org/apache/eventmesh/dashboard/common/enums/DataStatus.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/apache/eventmesh/dashboard/common/enums/metadata/MetadataTypeEnum.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/eventmesh/dashboard/common/enums/metadata/MetadataServiceTypeEnum.java
Outdated
Show resolved
Hide resolved
.../main/java/org/apache/eventmesh/dashboard/common/enums/metadata/MetadataServiceTypeEnum.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/apache/eventmesh/dashboard/common/enums/metadata/MetadataTypeEnum.java
Outdated
Show resolved
Hide resolved
Comment on lines
+20
to
+23
| public class CreateAclResponse { | ||
|
|
||
| Boolean success; | ||
| } |
There was a problem hiding this comment.
What's the difference between Response and Result?
There was a problem hiding this comment.
result have a future of response
...n/src/main/java/org/apache/eventmesh/dashboard/common/model/remoting/acl/GetAclsRequest.java
Show resolved
Hide resolved
Comment on lines
+22
to
+25
| public class GetClientResult { | ||
|
|
||
| CompletableFuture<GetClientResponse> getClientResponseFuture; | ||
| } |
There was a problem hiding this comment.
Is it necessary to warp CompletableFuture<GetClientResponse> into GetClientResult?
There was a problem hiding this comment.
for a clearer division of responsibilities
Comment on lines
35
to
36
|
|
||
| private List<String> brokerAddress; |
Comment on lines
34
to
37
|
|
||
| List<ConfigMetadata> configMetadataList; | ||
| private Boolean success; | ||
| } |
There was a problem hiding this comment.
It seems that configMetadataList is missing a private decorator.
Pil0tXia
reviewed
Mar 29, 2024
Comment on lines
25
to
28
|
|
||
| private GroupMetadata groupMetadata; | ||
| private String bootStrapServers; | ||
|
|
||
| private String groupName; |
There was a problem hiding this comment.
It should be bootstrap instead of bootStrap as bootstrap is a single word.
Is there any relationship between GetOffsetRequest and these two members?
There was a problem hiding this comment.
I'm not sure, what fields are needed for a request, developers who implement these remoting services can modify the fields
There was a problem hiding this comment.
okay, then lets leave a TODO comment and delete these members.
There was a problem hiding this comment.
You may finish this part in the next PR.
Comment on lines
30
to
31
| //center url | ||
| private String registryAddress; |
There was a problem hiding this comment.
center naming shall be replaced.
…q) (apache#66) * modify RocketmqTopicCore, using SDKManager * fix style * delete some variable in RocketmqProperties and TopicProperties & remote additional endPoint name * remove junit dependency back to console module * remove unnecessary brackets & revert em-dashboard-pom.xml & move RocketmqProperties to core.dto * add todo * move todo to common sdk dependencies & fix style * add test and junit dependencies in core pom.xml * revert the indentation in pom.xml & move test related dependencies to bottom in core-pom.xml * revert indentation in pom.xml * revert indentation in pom.xml * remove unnecessary params * remove params * remove empty line
|
You may finish the |
Pil0tXia
approved these changes
Mar 29, 2024
SLSJL
pushed a commit
to SLSJL/eventmesh-dashboard
that referenced
this pull request
Mar 31, 2024
…to dev * 'dev' of https://github.com/SLSJL/eventmesh-dashboard: [ISSUE apache#73] Add remoting service (apache#74) [ISSUE apache#45] Implement methods from storage-plugin.admin(rocketmq) (apache#66) [ISSUE apache#71] Reduce log file size and Streamline debug output (apache#72) [ISSUE apache#69] Integrate database credentials in auto-deploy (apache#70) [ISSUE apache#67] Fix HealthCheckResultMapper which leads to application error [ISSUE apache#64] Support automated deployment and Fix runtime packaging errors (apache#65) [ISSUE apache#60] add SDK manager (apache#62) [ISSUE apache#57] Modify the field, synchronize the modification, and add the mapper method (apache#58) [ISSUE apache#29] Set up EventMesh Dashboard Front-end (apache#56) [ISSUE apache#49] RocketMQ and Nacos health check (apache#53) [ISSUE apache#51] Config Mgmt basic function and config,runtime,store,cluster SQL (apache#52) # Conflicts: # eventmesh-dashboard-view/public/index.html # eventmesh-dashboard-view/src/App.tsx # eventmesh-dashboard-view/src/index.tsx # eventmesh-dashboard-view/src/routes/RootLayout.tsx # eventmesh-dashboard-view/src/routes/navigation/Navigation.tsx # eventmesh-dashboard-view/src/routes/navigation/NavigationItem.tsx # eventmesh-dashboard-view/src/routes/topic/Topic.tsx # eventmesh-dashboard-view/src/routes/topic/stats/AbnormalTopicCount.tsx # eventmesh-dashboard-view/src/routes/topic/stats/Stats.tsx # eventmesh-dashboard-view/src/routes/topic/stats/StatsChart.tsx # eventmesh-dashboard-view/src/routes/topic/stats/TopicCount.tsx # eventmesh-dashboard-view/src/routes/topic/topic-list/TopicList.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.